Frontend/bugfix #18
Frontend/bugfix #18
Conversation
…verlap about contnent overlap bug
…imum height to 80vh
|
Does this pull request fix any of the bugs mentioned here? |
|
Yes Bug #2 |
|
The bug was due to poor container sizing. If you just calculate the height and width of the box, it will resize with the browser window. You might think that it is a good feature, but keep in mind that the bug is caused by the inspector box. To mitigate this, instead of statically calculating the height and width of the grid container, we put a dynamic margin there. |
|
No, I mean, from this list, does it fix anything? |
|
Yes, it fixed the second bug the BUGS.md Mentioned It fixed this: https://github.com/p32929/p32929.github.io/blob/react/BUGS.md#bug2 |
Fixed Bug#2
Context: Rewrote Global Methods so it would react properly to dynamic desktop window size change.